Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of deserializing strings #300

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Feb 18, 2023

This addresses part of #214.

I recommend watching the excellent https://www.youtube.com/watch?v=BI_bHCGRgMY tutorial. I mostly followed the implementation of the standard library String type.

@esteve
Copy link
Collaborator

esteve commented Feb 19, 2023

@nnmm cool! Looks like there's an issue with the generated Python files for rclrs_example_msgs, but it's not cause by this PR, might be a problem in rolling.

@nnmm
Copy link
Contributor Author

nnmm commented Feb 22, 2023

@esteve yeah. Unfortunately the workaround suggested in ros-tooling/action-ros-ci#795 didn't seem to actually work around, so we'd have to wait for the next Rolling sync. Can we somehow make CI allow failure (for this specific check or entirely) until then?

@esteve
Copy link
Collaborator

esteve commented Feb 26, 2023

@nnmm looks like that's a feature that users have requested (https://github.com/orgs/community/discussions/15452), I don't know of any other way to allow a job to fail. I think the best we can do now is disable the rolling CI job until the next sync.

@esteve
Copy link
Collaborator

esteve commented Feb 26, 2023

@nnmm never mind, looks like continue-on-error might work in this case: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

@esteve
Copy link
Collaborator

esteve commented Feb 26, 2023

I've created #302 to allow the rolling job to fail, let's see if it works.

@nnmm nnmm force-pushed the improve_deserialization_efficiency branch from fcc6966 to 7b033ca Compare March 11, 2023 15:21
@nnmm
Copy link
Contributor Author

nnmm commented Mar 11, 2023

@esteve Could you take another look now that CI is green?

Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnmm thanks!

@esteve esteve merged commit 6939a8a into main Mar 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the improve_deserialization_efficiency branch March 12, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants