Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ros2-testing debs for rolling #308

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Mar 12, 2023

This PR uses the Debian packages from the testing repository for rolling so we can catch API incompatibilities earlier. Given that the rolling job is marked as continue-on-error and so it won't cause the entire CI fail, in case there are any build errors, PRs can still be merged.

@esteve esteve requested a review from a team March 30, 2023 09:07
@esteve esteve marked this pull request as ready for review March 30, 2023 09:08
Copy link
Contributor

@nnmm nnmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@esteve
Copy link
Collaborator Author

esteve commented Mar 30, 2023

@nnmm thanks for the prompt review.

@esteve esteve merged commit 3d22cbe into ros2-rust:main Mar 30, 2023
@esteve esteve deleted the use-ros2-testing-for-rolling branch March 30, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants