Add service_is_ready() #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Carter12s so good to see you here! 🙂 Overall, the changes look good, can you fix the |
|
@esteve Happy to be here! Updated |
jhdcs
approved these changes
Oct 25, 2023
esteve
approved these changes
Oct 26, 2023
|
@Carter12s thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging around for some low hanging fruit issues to get my feet wet with the crate and found #218 that was stuck in limbo.
Since I saw that #249 had merged with support for guard conditions I thought I might take a crack at revising that MR. After digging in for a bit I came to the conclusion that #249 didn't include all needed tooling and that to match the rclcpp implementation we'd need support for graph events (I think?).
That was more than I was ready to bite off, but I decided part of the #218 was still of value, so submitted a trimmed down version of that here.