-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
412 impl error to param errors #418
Closed
Guelakais
wants to merge
10
commits into
ros2-rust:main
from
Guelakais:412_impl_error_to_param_errors
Closed
412 impl error to param errors #418
Guelakais
wants to merge
10
commits into
ros2-rust:main
from
Guelakais:412_impl_error_to_param_errors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation warnings are annoying. So i've get rid of them.
the rust version causes errors. You'll need at least rust version 1.70 to have stable compiling
I mean for real: How patient do you'll need to be to not get annoyed by the whole serde warnings?
Guelakais
force-pushed
the
412_impl_error_to_param_errors
branch
from
October 2, 2024 09:57
fb9f9c3
to
02539ff
Compare
I'm currently stuck with the following: thread 'node::graph::tests::test_graph_empty' panicked at core/src/panicking.rs:221:5:
unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
stack backtrace:
0: 0x557628371f7a - std::backtrace_rs::backtrace::libunwind::trace::h81cef872b6d8b6fe
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/../../backtrace/src/backtrace/libunwind.rs:116:5
1: 0x557628371f7a - std::backtrace_rs::backtrace::trace_unsynchronized::h669cf78d55326f5f
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
2: 0x557628371f7a - std::sys::backtrace::_print_fmt::hb4c7a662c3bf03ea
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/backtrace.rs:66:9
3: 0x557628371f7a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h931fa8a693ee76bf
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/backtrace.rs:39:26
4: 0x557628398c2b - core::fmt::rt::Argument::fmt::h564d7b5469eb0ebc
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/fmt/rt.rs:177:76
5: 0x557628398c2b - core::fmt::write::ha344a87a3011b8f5
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/fmt/mod.rs:1186:21
6: 0x55762836e813 - std::io::Write::write_fmt::ha4f1ac9a9087f93c
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/io/mod.rs:1823:15
7: 0x557628371dc2 - std::sys::backtrace::BacktraceLock::print::h2930c514ae5653cd
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/backtrace.rs:42:9
8: 0x5576283736f5 - std::panicking::default_hook::{{closure}}::hc7a5b0b766fd5663
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:268:22
9: 0x557628373524 - std::panicking::default_hook::h9d542ef7bbd51eed
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:295:9
10: 0x55762832a6c9 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h5b3967df2fa6ebfb
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/alloc/src/boxed.rs:2467:9
11: 0x55762832a6c9 - test::test_main::{{closure}}::h322d55900e01cadf
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:132:21
12: 0x557628373df8 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h20599c4ffa11ca76
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/alloc/src/boxed.rs:2467:9
13: 0x557628373df8 - std::panicking::rust_panic_with_hook::h426e85c59c56abd7
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:809:13
14: 0x557628373b86 - std::panicking::begin_panic_handler::{{closure}}::hdbed8eca2a1d0322
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:667:13
15: 0x557628372459 - std::sys::backtrace::__rust_end_short_backtrace::hfaec60235a9405e1
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/backtrace.rs:170:18
16: 0x55762837384c - rust_begin_unwind
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:665:5
17: 0x5576283973bd - core::panicking::panic_nounwind_fmt::runtime::h88fad673df5dec83
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/panicking.rs:112:18
18: 0x5576283973bd - core::panicking::panic_nounwind_fmt::h33f53e866e257bf9
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/panicking.rs:122:5
19: 0x557628397452 - core::panicking::panic_nounwind::h7af5d10c4e74c5c0
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/panicking.rs:221:5
20: 0x557628185d6e - core::slice::raw::from_raw_parts::precondition_check::h5d65949de3e5cf4a
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/ub_checks.rs:70:21
21: 0x55762817243f - core::slice::raw::from_raw_parts::h886f5e075540af19
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/ub_checks.rs:77:17
22: 0x557628290842 - rclrs::node::graph::convert_names_and_types::h5637fd8f47090e39
at /ros_debug_ws/src/ros2_rust/rclrs/src/node/graph.rs:426:9
23: 0x557628190d4b - rclrs::node::graph::<impl rclrs::node::Node>::get_names_and_types_by_node::h42ef19c8f4c2ffca
at /ros_debug_ws/src/ros2_rust/rclrs/src/node/graph.rs:346:12
24: 0x55762818eab5 - rclrs::node::graph::<impl rclrs::node::Node>::get_publisher_names_and_types_by_node::h275336b0376456b6
at /ros_debug_ws/src/ros2_rust/rclrs/src/node/graph.rs:87:9
25: 0x557628194172 - rclrs::node::graph::tests::test_graph_empty::h9de28984da3747c9
at /ros_debug_ws/src/ros2_rust/rclrs/src/node/graph.rs:494:32
26: 0x55762818e597 - rclrs::node::graph::tests::test_graph_empty::{{closure}}::h4da847ac4042ed03
at /ros_debug_ws/src/ros2_rust/rclrs/src/node/graph.rs:463:26
27: 0x55762824bc76 - core::ops::function::FnOnce::call_once::h0e6e8b5eaff563ed
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/ops/function.rs:250:5
28: 0x55762832ef4b - core::ops::function::FnOnce::call_once::h9c15004a247e8a5b
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/ops/function.rs:250:5
29: 0x55762832ef4b - test::__rust_begin_short_backtrace::h2061fd54cfd972a6
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:620:18
30: 0x55762832e878 - test::run_test_in_process::{{closure}}::hd2fa346499c48626
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:643:60
31: 0x55762832e878 - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h2d75ee7fd0a9190d
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/panic/unwind_safe.rs:272:9
32: 0x55762832e878 - std::panicking::try::do_call::h2997f9dc8b461edf
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:557:40
33: 0x55762832e878 - std::panicking::try::h18593abcbc594542
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:520:19
34: 0x55762832e878 - std::panic::catch_unwind::h95688020d6162b5c
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panic.rs:348:14
35: 0x55762832e878 - test::run_test_in_process::h91f8fbf33aac224f
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:643:27
36: 0x55762832e878 - test::run_test::{{closure}}::h478ff2bd8d88e648
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:564:43
37: 0x5576282f2ac4 - test::run_test::{{closure}}::h58710e4947ab2cfa
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/test/src/lib.rs:594:41
38: 0x5576282f2ac4 - std::sys::backtrace::__rust_begin_short_backtrace::heda3a45ef2e2e229
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/backtrace.rs:154:18
39: 0x5576282f6212 - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::h3f109e50385c685c
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/thread/mod.rs:522:17
40: 0x5576282f6212 - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::he937fd500903adc6
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/panic/unwind_safe.rs:272:9
41: 0x5576282f6212 - std::panicking::try::do_call::h02ec682b6067af95
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:557:40
42: 0x5576282f6212 - std::panicking::try::h0f2d650f80ce88df
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panicking.rs:520:19
43: 0x5576282f6212 - std::panic::catch_unwind::h45b74ae33d713a82
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/panic.rs:348:14
44: 0x5576282f6212 - std::thread::Builder::spawn_unchecked_::{{closure}}::h9d9f63b654f81360
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/thread/mod.rs:521:30
45: 0x5576282f6212 - core::ops::function::FnOnce::call_once{{vtable.shim}}::hfd039c59ce62e18e
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/core/src/ops/function.rs:250:5
46: 0x557628377ffb - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hb08cd83589a97d3d
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/alloc/src/boxed.rs:2453:9
47: 0x557628377ffb - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h849827a9b2c78c58
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/alloc/src/boxed.rs:2453:9
48: 0x557628377ffb - std::sys::pal::unix::thread::Thread::new::thread_start::h172f6b61f4e28e39
at /rustc/506f22b4663f3e756e1e6a4f66c6309fdc00819c/library/std/src/sys/pal/unix/thread.rs:105:17
49: 0x7fb3d1694ac3 - <unknown>
50: 0x7fb3d1726850 - <unknown>
51: 0x0 - <unknown>
thread caused non-unwinding panic. aborting.
error: test failed, to rerun pass `--lib`
Caused by:
process didn't exit successfully: `/ros_debug_ws/build/rclrs/debug/deps/rclrs-435f06b0d3cdbafe --color=never --quiet` (signal: 6, SIGABRT: process abort signal)
---
Finished <<< rclrs [4.59s] [ with test failures ]
Summary: 1 package finished [5.40s]
1 package had stderr output: rclrs
1 package had test failures: rclrs
root@steamdeck:/ros_debug_ws# |
@Guelakais A fix for #412 has already been submitted at #413, have you checked it before submitting this PR? |
Closing in favor of #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.