Use text replacement to modify dockerfile once/day for windows #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
commented
Apr 9, 2020
| @@ -84,7 +83,7 @@ RUN mkdir C:\ws | |||
| WORKDIR C:\ci | |||
|
|
|||
| # Invalidate once a day to cause online installers to check for updates | |||
| RUN echo %TODAYS_DATE% | |||
| RUN echo "@todays_date" | |||
There was a problem hiding this comment.
Becomes:
RUN echo "Thursday, April 9, 2020"
cottsay
approved these changes
Apr 9, 2020
nuclearsandwich
approved these changes
Apr 9, 2020
| @@ -357,10 +357,13 @@ echo "# BEGIN SECTION: Build DockerFile" | |||
| set CONTAINER_NAME=ros2_windows_ci_msvc%CI_VISUAL_STUDIO_VERSION% | |||
| set DOCKERFILE=windows_docker_resources\Dockerfile.msvc%CI_VISUAL_STUDIO_VERSION% | |||
|
|
|||
| rem "Change dockerfile once per day to invalidate docker caches" | |||
| powershell "(Get-Content ${Env:DOCKERFILE}).replace('@todays_date', $(Get-Date).ToLongDateString()) | Set-Content ${Env:DOCKERFILE}" | |||
There was a problem hiding this comment.
I forgot that this would need to be escaped in order for empty to render the @-sign through: #426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach of using a dockerfile
ARGwould not actually invalidate caches once-per-day as a--build-argis apparently not part of the context.This implements a solution similar to
sedwhich is used with the linux dockerfile.