Split windows dockerfiles for different ROS distros. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One for Dashing (and Eloquent) and one for Foxy. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Rather than using separate Dockerfiles for separate Visual Studio versions, do so based on the CI_ROS_DISTRO parameter. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Dashing and Eloquent share supported Python and OpenSSL versions and so can share a Dockerfile. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
|
Nitpick: it would have been nice to maintain the history of Dockerfile for Foxy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now both Dockerfiles are identical but this split will allow us to start using Python 3.8 (#432) and OpenSSL 1.1.1 (#421) in Foxy without dropping support for building Dashing and Eloquent.
Test builds with both Dockerfiles just building rcutils (just validating parameter as the files are currently identical).
Foxy
Dashing