Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug wheels used on Windows. #453

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

nuclearsandwich
Copy link
Member

This updates the Debug wheels for Python 3.8.

In order to support builds of Dashing and Eloquent we'll need to come
back to this and add support for using a different set of wheels for the
older python version but this hopefully gets us the Windows debug nightlies back.

This updates the Debug wheels for Python 3.8.

In order to support builds of Dashing and Eloquent we'll need to come
back to this and add support for using a different set of wheels for the
older python version but this hopefully gets us nightlies back.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich self-assigned this May 20, 2020
@nuclearsandwich
Copy link
Member Author

All I did was build up to ament_mypy in order to test that everything was installable.

Debug build: Build Status

Sanity non-Debug build: Build Status

@nuclearsandwich
Copy link
Member Author

I'm going to merge this PR in order to give the nightlies a chance. As mentioned there's outstanding work required to restore Dashing and Eloquent builds and these wheels could still cause problems during build or test but I'm willing to find that out in the next round of nightlies since this will at least not fail during pip install.

@nuclearsandwich nuclearsandwich merged commit 37ba0ec into master May 20, 2020
@nuclearsandwich nuclearsandwich deleted the foxy-debug-wheels branch May 20, 2020 04:01
@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented May 20, 2020

With this patch the debug job is now showing failures building rosidl_generator_py

00:26:49.088 C:\Python38\lib\site-packages\numpy\core\include\numpy\numpyconfig.h(4,10): fatal error C1083: Cannot open include file: '_numpyconfig.h': No such file or directory (compiling source file C:\ci\ws\build\rosidl_generator_py\rosidl_generator_py\rosidl_generator_py\msg\_unbounded_sequences_s.c) [C:\ci\ws\build\rosidl_generator_py\rosidl_generator_py_custom__python.vcxproj]

00:26:49.088 C:\Python38\lib\site-packages\numpy\core\include\numpy\numpyconfig.h(4,10): fatal error C1083: Cannot open include file: '_numpyconfig.h': No such file or directory (compiling source file C:\ci\ws\build\rosidl_generator_py\rosidl_generator_py\rosidl_generator_py\msg\_string_arrays_s.c) [C:\ci\ws\build\rosidl_generator_py\rosidl_generator_py_custom__python.vcxproj]

https://ci.ros2.org/view/nightly/job/nightly_win_deb/1626/console#console-section-67

@nuclearsandwich
Copy link
Member Author

I think our wheel was affected by numpy/numpy#16005
I used a workaround similar to the one proposed in that issue. If Build Status is successful I'll update the upstream issue with my exact workaround and try to figure out what a PR would look like to resolve the underlying issue.

@nuclearsandwich
Copy link
Member Author

That worked so I started a full build to try and catch the next things before nightlies. Build Status

@nuclearsandwich
Copy link
Member Author

nuclearsandwich commented May 20, 2020

My last build failed because I pre-emptively built the Cryptography wheel against OpenSSL 1.1.1 rather than 1.0.2. I am trying to run another without sros2 and test_security to avoid that particular break while I iterate on the OpenSSL 1.1.1 PR for Foxy.

Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant