Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest to 6.0.2 #515

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Pin pytest to 6.0.2 #515

merged 1 commit into from
Sep 28, 2020

Conversation

clalancette
Copy link
Contributor

@clalancette clalancette commented Sep 28, 2020

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

pytest got upgraded to 6.1.0, and for some reason no longer works with our system. Until we figure out why, pin pytest back to 6.0.2, which does work.

Before: Build Status
After: Build Status

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems to me that is working as expected. root cause could be related to:

CMake Warning at /home/jenkins-agent/workspace/ci_linux-aarch64/ws/install/ament_cmake_pytest/share/ament_cmake_pytest/cmake/ament_add_pytest_test.cmake:77 (message):
  The Python module 'pytest' was not found, pytests can not be run (e.g.  on
  Ubuntu/Debian install the package 'python3-pytest')
Call Stack (most recent call first):
  CMakeLists.txt:31 (ament_add_pytest_test)

@ivanpauno
Copy link
Member

When I update to 6.1.0 and run pytest locally I get:

  File "/home/ivanpauno/.local/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 171, in exec_module
    exec(co, module.__dict__)
  File "/usr/local/lib/python3.8/dist-packages/pytest_rerunfailures.py", line 8, in <module>
    from _pytest.resultlog import ResultLog
ModuleNotFoundError: No module named '_pytest.resultlog'

So it seems that the last pytest update broke pytest-rerunfailures.
There's already an upstream issue: pytest-dev/pytest-rerunfailures#128.

@clalancette
Copy link
Contributor Author

So it seems that the last pytest update broke pytest-rerunfailures.

There's already an upstream issue: pytest-dev/pytest-rerunfailures#128.

Ah, nice. Thanks for doing the additional research. I'm going to merge this for now, then open up a follow-up PR to unpin.

@clalancette clalancette merged commit b823ca2 into master Sep 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the pin-pytest branch September 28, 2020 14:05
clalancette added a commit that referenced this pull request Sep 28, 2020
clalancette added a commit that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants