Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes policy CMP0135 warning for CMake >= 3.24 (backport #36) #38

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 2, 2023

This is an automatic backport of pull request #36 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fixes policy CMP0135 warning for CMake >= 3.24

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
(cherry picked from commit 1d81843)
@clalancette
Copy link
Contributor

clalancette commented Jan 2, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@Crola1702
Copy link
Contributor

Crola1702 commented Jan 3, 2023

@clalancette windows build depends on:

@clalancette
Copy link
Contributor

@clalancette windows build depends on:

* `rviz_assimp_vendor` & `rviz_ogre_vendor` backport

Makes sense. I will go ahead and review those next. Thanks for the approval here!

@clalancette clalancette merged commit 37a1122 into humble Jan 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-36 branch January 3, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants