use ros2run api to handle KeyboardInterrupt #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the patch the surrounding launch file sends a
SIGINTto this script which will raise during thesubprocess.calland return non-zero.This seems to have failed a few tests in the past:
The patch uses the
ros2runAPI to handle the raisedKeyboardInterruptnicely and let the subprocess finish. The hope is that this makes the test not flaky anymore / less flaky.It retried 30 times without failing due to a
KeyboardInterrupt(which of course doesn't proof anything 😉):The later failure was a timeout -
pendulum_demowas hanging without ever printing the Connext license message. More on this in #177.