Migrate launch tests to new launch_testing features & API #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbaughman
reviewed
Apr 9, 2019
pbaughman
reviewed
Apr 9, 2019
hidmic
added
in review
29 tasks
hidmic
force-pushed
the
hidmic/import_launch_testing
branch
from
2075775 to
3bbc34f
Compare
jacobperron
approved these changes
Apr 29, 2019
|
We'll need to revisit some of the TODOs I've left here later on. Mainly, Fast-RTPS is taking unusually long to forward a service request within the same process. Or at least it manifests itself when trying to set parameters, see here. I've patched it because it's unrelated to these changes but we shuld revisit it afterwards. |
wjwwood
reviewed
Apr 29, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
force-pushed
the
hidmic/import_launch_testing
branch
from
c230b02 to
38eb873
Compare
wjwwood
reviewed
Apr 29, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Alright, CI failures are unrelated. Can I get another approval after latest changes? |
wjwwood
approved these changes
Apr 30, 2019
routiful
pushed a commit
to ROBOTIS-move/demos
that referenced
this pull request
May 7, 2019
* Update after launch_testing features becoming legacy. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Migrate demos tests to new launch_testing API. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Stop using injected attributes in launch tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Add launch_testing_ros as test dependency where necessary. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Fix bad process cmd on logging demo tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Fix bad output filter in logging demo tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Address peer review comments. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Fix failing demo_nodes_cpp launch tests Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Patch failing demo_nodes_cpp launch tests. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Alpha ordered some package.xml files. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Extended tests for parameter events. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Darby Lim <thlim@robotis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/launch#208.