Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid unstable LaserScan status for rviz2 #614

Merged
merged 1 commit into from
May 8, 2023
Merged

avoid unstable LaserScan status for rviz2 #614

merged 1 commit into from
May 8, 2023

Conversation

iuhilnehc-ynos
Copy link
Contributor

IDK whether it's a correct fix.
After referring to the gazebo to set time_increment with zero, the rviz2 issue reported in osrf/ros2_test_cases#868 works well.

avoid unstable LaserScan status for rviz2
175b551 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
@iuhilnehc-ynos iuhilnehc-ynos marked this pull request as ready for review May 8, 2023 05:16
clalancette
clalancette approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix doesn't seem completely right to me, in that we are lying about some of the data.

However, since Gazebo is doing something similar, I think this is OK to do. So I'm going to approve and run CI on it, thank you!

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 83046c2 into ros2:rolling May 8, 2023
@clalancette
Copy link
Contributor

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 8, 2023 •
edited
Loading

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 8, 2023
@mergify
avoid unstable LaserScan status for rviz2 (#614)
60969fd 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit 83046c2)
@mergify mergify bot mentioned this pull request May 8, 2023
Merged
clalancette pushed a commit that referenced this pull request May 8, 2023
@mergify
avoid unstable LaserScan status for rviz2 (#614) (#616)
95f7bd9 
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
(cherry picked from commit 83046c2)

Co-authored-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@audrow audrow Awaiting requested review from audrow

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuhilnehc-ynos @clalancette