Skip to content

Commit

Permalink
Minor updates per feedback.
Browse files Browse the repository at this point in the history
Distro A; OPSEC #2893

Signed-off-by: Roger Strain <rstrain@swri.org>
  • Loading branch information
Roger Strain committed Jul 15, 2020
1 parent 476a6df commit c95ba3d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions articles/execute_process_refactor.md
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ Most parameters would be passed to the superclass.

|Argument|Description|
|---|---|
| package | Optional. Name of the ROS package the node plugin lives in. If not specified, the package of the containing executable will be assumed. |
| package | Optional. Name of the ROS package the node plugin lives in. If not specified, the package of the containing executable will be assumed. This may fail if context regarding the executable is not available. |
|node_plugin|Name of the plugin to be loaded|

Additional parameters that may be passed, which are handled by `launch_ros.descriptions.NodeBase`: `node_name`, `node_namespace`, `parameters`, `remappings`, `arguments`, `traits`.
Expand Down Expand Up @@ -496,11 +496,10 @@ It would not include execution-time details, nor provide monitoring of the proce
| Argument | Description |
| --------------- | ------------------------------------------------------------ |
| package | name of the ROS package the node executable lives in |
|node_executable|Name of the executable to find|
| executable_name |Name of the executable to find|
| nodes | A list of `launch_ros.descriptions.Node` objects which are part of the executable. |

Additional parameters that may be passed, which are handled by `launch.actions.ExecuteProcess`: `cmd`, `name`, `cwd`, `env`, `additional_env`.
NOTE: To allow ROS to determine the appropriate executable based on the package and executable name, the `cmd` parameter should *NOT* be specified. When `cmd` is not specified, this class will determine the appropriate executable if and only if exactly one of the nodes it contains has the `launch_ros.traits.IsExecutable` trait.
Additional parameters that may be passed, which are handled by `launch.actions.Executable`: `name`, `cwd`, `env`, `additional_env`.

#### Properties

Expand Down

0 comments on commit c95ba3d

Please sign in to comment.