Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial eigen3_cmake_module package #1
Initial eigen3_cmake_module package #1
Changes from all commits
c08de4a
9b578d4
dc8f51f
c1b1e61
db2f49d
4b34900
3841fd7
59474ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to give a little more context here on this issue? In your explanation you mentioned the reasoning behind this package is that ament process for adding eigen3 as a dependency may not work in Ubuntu bionic. Would the user be able to recognize that that's the problem when their "library or executable using Eigen3" failed to compile? Would someone searching for a fix be able to recognize that this is for that exact issue?
For your audience to be convinced that this is the solution to their problem, I just want to make sure that the "solution" mentioned here is enough to do so.
Maybe "This enables ... in the event that ... (it fails because x)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more context about the problem in e78118d in #2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can gather, it seems like the whole purpose behind this package and the problem/solution here is 100% due to/reliant on ament. Would someone who wasn't using ament come across this problem? If yes, is there any other way to solve the problem without using ament?
"... assumes you're using.." makes it sound like there are other options, which might be misleading or confusing (or correct if my understanding of the situation is wrong!) Hinting at other options but not elaborating on them might be confusing. If there are other ways you might want to say something like:
"You can follow the ament syntax below to accomplish the same thing using < another build tool of choice >"
Otherwise I would either remove the statement or change it to convey "This section requires ament"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone not using
ament_cmake
would also notice thatEigen3
uses non-standard variable names. It's less of a problem for them since they have to do everything manually already.ament_cmake
packages have an issue because they use convenience functions (ament_target_dependencies()
,ament_export_dependencies()
) that make assumptions about the variable names.I added instructions for non-ament_cmake users in
3c1f634 in #2