Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait set examples #315

Merged
merged 59 commits into from
Jul 31, 2021
Merged

Add wait set examples #315

merged 59 commits into from
Jul 31, 2021

Commits on Jul 23, 2021

  1. wip

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    709f344 View commit details
    Browse the repository at this point in the history
  2. more WIP examples

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    fb71560 View commit details
    Browse the repository at this point in the history
  3. updates

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4fa827f View commit details
    Browse the repository at this point in the history
  4. adding examples using Subscription::take()

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    78bdd93 View commit details
    Browse the repository at this point in the history
  5. use rclcpp::MessageInfo

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f773850 View commit details
    Browse the repository at this point in the history
  6. break examples into separate files

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    593e5b9 View commit details
    Browse the repository at this point in the history
  7. update to support thread-safe wait set

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b4b41e3 View commit details
    Browse the repository at this point in the history
  8. style

    Signed-off-by: William Woodall <william@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    e915fce View commit details
    Browse the repository at this point in the history
  9. Add addtional wait-set examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ebcc4c7 View commit details
    Browse the repository at this point in the history
  10. Shuffle publish calls

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    09749ff View commit details
    Browse the repository at this point in the history
  11. Refactor publisher in a node class

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4c7cf9a View commit details
    Browse the repository at this point in the history
  12. Update examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    35d4e7a View commit details
    Browse the repository at this point in the history
  13. Add waiset example using composition

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d197ed4 View commit details
    Browse the repository at this point in the history
  14. Rename minimal_subscriber waitset example

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4274987 View commit details
    Browse the repository at this point in the history
  15. Update README

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    3b3e1f4 View commit details
    Browse the repository at this point in the history
  16. Update waitset_example_main

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    04eba55 View commit details
    Browse the repository at this point in the history
  17. Refactoring

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f4f556e View commit details
    Browse the repository at this point in the history
  18. Add example using different topic rates

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    db804b7 View commit details
    Browse the repository at this point in the history
  19. Rename examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    54de281 View commit details
    Browse the repository at this point in the history
  20. Use handle_message to handle callbacks

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    27dc9de View commit details
    Browse the repository at this point in the history
  21. Refactor random talker example

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    65cf4fc View commit details
    Browse the repository at this point in the history
  22. Fix cpplint errors

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ce06acc View commit details
    Browse the repository at this point in the history
  23. Rename executables

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    3197c11 View commit details
    Browse the repository at this point in the history
  24. Add minimal subscriber example using a timer triggered node

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f477010 View commit details
    Browse the repository at this point in the history
  25. Fix incomplete executable name

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    59a6c65 View commit details
    Browse the repository at this point in the history
  26. Complete README.md

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    e0cf1d6 View commit details
    Browse the repository at this point in the history
  27. Refactor wait-set policies examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ca67af0 View commit details
    Browse the repository at this point in the history
  28. Refactor MinimalSubscriber wait-set examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    fd993eb View commit details
    Browse the repository at this point in the history
  29. Document missing wait-set examples

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d7d7006 View commit details
    Browse the repository at this point in the history
  30. Fix incorrect path for README.md

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    8c70ccb View commit details
    Browse the repository at this point in the history
  31. Style fixes

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    e910755 View commit details
    Browse the repository at this point in the history
  32. Replace RCLCPP_ERROR with RCLCPP_WARN

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5c82c7d View commit details
    Browse the repository at this point in the history
  33. Update rclcpp/wait_set/wait_set_topics_and_timer.cpp

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f3116d1 View commit details
    Browse the repository at this point in the history
  34. Update rclcpp/minimal_subscriber/README.md

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6d4c362 View commit details
    Browse the repository at this point in the history
  35. Spin nodes in executor

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2792baa View commit details
    Browse the repository at this point in the history
  36. Remove out of place line

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    514acdc View commit details
    Browse the repository at this point in the history
  37. Rename Listener to RandomListener

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1da4bd2 View commit details
    Browse the repository at this point in the history
  38. Move wait-set loop thread to the node

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    a8dd4fb View commit details
    Browse the repository at this point in the history
  39. Minimize vertical whitespace

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    de22d00 View commit details
    Browse the repository at this point in the history
  40. Register nodes as components

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1183764 View commit details
    Browse the repository at this point in the history
  41. Rename waitset to wait_set

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    23bcb7a View commit details
    Browse the repository at this point in the history
  42. Add minimal siatic wait-set subscriber example

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    252deef View commit details
    Browse the repository at this point in the history
  43. Refactor CMakeLists.txt

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    fbe1026 View commit details
    Browse the repository at this point in the history
  44. Remove comment about simulating inter-process communications

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    53212bf View commit details
    Browse the repository at this point in the history
  45. Add joinable

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7971186 View commit details
    Browse the repository at this point in the history
  46. README.md format

    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4eb028a View commit details
    Browse the repository at this point in the history
  47. Update rclcpp/minimal_subscriber/static_wait_set.cpp

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    06caa2a View commit details
    Browse the repository at this point in the history
  48. Update rclcpp/minimal_subscriber/wait_set.cpp

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    642ecf6 View commit details
    Browse the repository at this point in the history
  49. Update rclcpp/minimal_subscriber/wait_set_time_triggered.cpp

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    07679a4 View commit details
    Browse the repository at this point in the history
  50. Adress reviewer comments for minimal_subscriber

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    555a590 View commit details
    Browse the repository at this point in the history
  51. Convert wait-set minimal subscribers to components

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    4ec7f9f View commit details
    Browse the repository at this point in the history
  52. Add note in README for wait-set use cases

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    44f2239 View commit details
    Browse the repository at this point in the history
  53. Restore rclcpp/README.md modified indent

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    8831ddd View commit details
    Browse the repository at this point in the history
  54. Remove dll compile definitions

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6027fb7 View commit details
    Browse the repository at this point in the history
  55. Minor fixes

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b747282 View commit details
    Browse the repository at this point in the history
  56. Use rclcpp_components_register_node to register components

    Signed-off-by: Carlos San Vicente <carlos.sanvicente@apex.ai>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg authored and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    cf714a9 View commit details
    Browse the repository at this point in the history
  57. Update rclcpp/topics/minimal_subscriber/README.md

    Co-authored-by: William Woodall <william+github@osrfoundation.org>
    Signed-off-by: Carlos San Vicente <carlos.svic@gmail.com>
    Signed-off-by: William Woodall <william@osrfoundation.org>
    carlossvg and wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1dff75f View commit details
    Browse the repository at this point in the history
  58. fix signed converison or potential loss of data warnings

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7d63434 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2021

  1. avoid conversion warnings by using size_t everywhere

    Signed-off-by: William Woodall <william@osrfoundation.org>
    wjwwood committed Jul 31, 2021
    Configuration menu
    Copy the full SHA
    de2962f View commit details
    Browse the repository at this point in the history