Catch polymorphic exceptions by reference (#138)

Signed-off-by: Scott K Logan <logans@cottsay.net>
ros2 · Jul 27, 2019 · e29db0a · e29db0a
1 parent 93baeac
commit e29db0a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tf2_ros/src/create_timer_ros.cpp b/tf2_ros/src/create_timer_ros.cpp
@@ -76,7 +76,7 @@ CreateTimerROS::reset(const TimerHandle & timer_handle)
   std::lock_guard<std::mutex> lock(timers_map_mutex_);
   try {
     timers_map_.at(timer_handle)->reset();
-  } catch (const std::out_of_range) {
+  } catch (const std::out_of_range &) {
     throw InvalidTimerHandleException("Invalid timer handle in reset()");
   }
 }
@@ -87,7 +87,7 @@ CreateTimerROS::remove(const TimerHandle & timer_handle)
   std::lock_guard<std::mutex> lock(timers_map_mutex_);
   try {
     cancelNoLock(timer_handle);
-  } catch (const InvalidTimerHandleException) {
+  } catch (const InvalidTimerHandleException &) {
     throw InvalidTimerHandleException("Invalid timer handle in remove()");
   }
   timers_map_.erase(timer_handle);
@@ -98,7 +98,7 @@ CreateTimerROS::cancelNoLock(const TimerHandle & timer_handle)
 {
   try {
     timers_map_.at(timer_handle)->cancel();
-  } catch (const std::out_of_range) {
+  } catch (const std::out_of_range &) {
     throw InvalidTimerHandleException("Invalid timer handle in cancel()");
   }
 }