Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force explicit --ros-args in NodeOptions::arguments(). #162

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 4, 2019

Precisely what the title says. Follow-up after ros2/rclcpp#816 and ros2/rclpy#405 (comment). Necessary for ros2/rcl#493 considering ros2/rclcpp#784.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from wjwwood and ivanpauno September 4, 2019 17:31
@hidmic hidmic merged commit 6249781 into ros2 Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/explicit-ros-args branch September 5, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants