-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes timer global init of event handler #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use an attribute on the context to see if we need to install the timer callback event handler - Add a regression test that fails (hangs, actually) before the fix was applied
pbaughman
changed the title
Fixes timer global init of event handler
ISSUE183 Fixes timer global init of event handler
Feb 13, 2019
wjwwood
requested changes
Feb 13, 2019
Other than one small implementation detail, this lgtm. |
wjwwood
changed the title
ISSUE183 Fixes timer global init of event handler
Fixes timer global init of event handler
Feb 13, 2019
Co-Authored-By: pbaughman <dblue135@yahoo.com>
wjwwood
approved these changes
Feb 13, 2019
1 task
Hah - my different version of flake8 strikes again. . .
|
That might also be that you're missing some of the flake8 extensions we use, but I'm not sure. I think the quote style one is an extension (again not 100% sure, but I think I remember that being the case). |
I'll rerun CI quickly if you can fix those up, so we can unblock #181. |
wjwwood
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
callback event handler
I manually verified that a launch description containing multiple timers would only register the TimerEvent handler once.