Fix parsing of cmd line arguments in XML and yaml file #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
reviewed
Feb 14, 2020
hidmic
reviewed
Feb 14, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
approved these changes
Feb 14, 2020
|
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
Fixed linter failures in 6e74c91, the other failures are also happening in nightlies.
It would be possible to tweak the grammar and add a different Transformer to get directly a list of arguments, instead of manually converting one thing to the other. |
delete-merged-branch
bot
deleted the
ivanpauno/fix-substitutions-in-cmd-argument
branch
ivanpauno
added a commit
that referenced
this pull request
Apr 16, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337.
The rules are a bit tricky, but I added a bunch of test cases. I will add any other suggested test case if needed.
I first though about solving the problem by addressing #263.
But I later realized that:
SomeSubstitutionsType) for specifying commands, instead of a list (List[SomeSubstitutionsType]), makes concatenation of arguments more complex (e.g.: when passing args fromNodetoExecuteProcess).