Let XML executables/nodes be "required" (like in ROS 1) #751
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> Signed-off-by: Matthew Elwin <elwin@northwestern.edu>
m-elwin
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
|
👍
Linking related issue #174 and PR #179 added similar support for Python launch files via Py Example: nodes_to_launch.append(
Node(
package="my_example_pkg",
executable="example_node_main",
name="example_node",
...
on_exit=Shutdown(),
)
) |
clalancette
requested changes
Jan 2, 2024
| if 'on_exit' not in ignore: | ||
| on_exit = entity.get_attr('on_exit', optional=True) | ||
| if on_exit is not None: | ||
| if on_exit == "shutdown": |
There was a problem hiding this comment.
Our style prefers single-quotes:
Suggested change
| if on_exit == "shutdown": | |
| if on_exit == 'shutdown': |
Signed-off-by: Matthew Elwin <elwin@northwestern.edu>
|
Thanks. Fixed the quotes and added a unit test for the yaml support. I think the code I added automatically covers both xml and yaml cases, but please let me know if I'm missing something. |
clalancette
approved these changes
Jan 3, 2024
|
CI:
|
Timple
pushed a commit
to nobleo/launch
that referenced
this pull request
Mar 5, 2024
* Let XML nodes be "required" Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <elwin@northwestern.edu>
Timple
pushed a commit
to nobleo/launch
that referenced
this pull request
Mar 5, 2024
* Let XML nodes be "required" Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <elwin@northwestern.edu> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
mjcarroll
pushed a commit
that referenced
this pull request
Mar 20, 2024
#764) Backport #751 for Iron Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <elwin@northwestern.edu> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
jplapp
pushed a commit
to pixel-robotics/launch
that referenced
this pull request
May 11, 2024
ros2#764) Backport ros2#751 for Iron Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <elwin@northwestern.edu> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
|
I can see this being backported to iron. Is there a plan to move this to humble as well? |
monicaperezserrano
pushed a commit
to monicaperezserrano/launch
that referenced
this pull request
Dec 20, 2024
* Let XML nodes be "required" Essentially on_exit="shutdown" is equivalent to ROS 1 required="true". This feature is implemented using the python launchfile on_exit mechanism. Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later. Example: <executable cmd="ls" on_exit="shutdown"/> * Added tests for yaml Signed-off-by: Matthew Elwin <elwin@northwestern.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially on_exit="shutdown" is equivalent to ROS 1 required="true".
This feature is implemented using the python launchfile on_exit= mechanism.
Right now "shutdown" is the only action accepted by on_exit, but theoretically more "on_exit" actions could be added later.
Example: