Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected matches_action usage in lifecycle_pub_sub example #21

Merged

Conversation

ivanpauno
Copy link
Member

launch_ros/examples/lifecycle_pub_sub_launch.py is broken since ros2/launch#167.
This fixes the example.

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review labels May 9, 2019
@ivanpauno ivanpauno requested a review from hidmic May 9, 2019 13:08
@ivanpauno ivanpauno self-assigned this May 9, 2019
@ivanpauno
Copy link
Member Author

ivanpauno commented May 10, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 9a6ed82 into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/correct-lifecycle-pub-sub-launch-example branch May 10, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants