Support launch_ros test runner in pytest #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Aug 21, 2019
There was a problem hiding this comment.
As I commented in ros2/launch#312, I don't fully understand pytest plugins. But if it works, I'm ok with the changes.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Aug 21, 2019
|
All green! Going in. |
dirk-thomas
reviewed
Aug 23, 2019
| ``` | ||
|
|
||
| This test launches the talker and listener example nodes from demo\_nodes\_py and interacts | ||
| with them via their ROS interfaces. Remapping rules are used so that one of the tests can sit in |
There was a problem hiding this comment.
New sentence should start on new line.
Same below.
There was a problem hiding this comment.
Oops. It predates the PR but you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request customizes launch tests collection via
pytestto make use of its ownLaunchTestRunnerwhenever agenerate_test_descriptionis found and it carries arostestmarker.Connected to ros2/launch#312.