Add substitution for finding package share directory #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose FindPackageShare as 'find-pkg' and FindPackage as 'find-pkg-root'.
The rationale is that getting the share directory is the more common use-case (e.g. including launch files).
This turns
<include file="$(find-pkg foo)/share/foo/launch/foo.launch.xml">
into
<include file="$(find-pkg foo)/launch/foo.launch.xml">
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
|
I don't think "root" is a good term here. The term used everywhere else for this basepath is (install) "prefix". I would rather prefer both substitutions to be explicit ( |
👍 for I kept |
|
Design doc PR: https://github.com/ros2/design/pull/254/files |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Windows: |
hidmic
reviewed
Sep 5, 2019
FindPackage is now an abstract class that requires subclasses to implement a 'find' method. FindPackagePrefix is the subclass that finds the package prefix. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose FindPackageShare as 'find-pkg' and FindPackage as 'find-pkg-root'.
The rationale is that getting the share directory is the more common use-case (e.g. including launch files).
This turns
into