Skip to content
This repository has been archived by the owner on Apr 23, 2020. It is now read-only.

parameter::ParameterVariant -> Parameter #28

Merged
merged 1 commit into from
Jun 4, 2018
Merged

parameter::ParameterVariant -> Parameter #28

merged 1 commit into from
Jun 4, 2018

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Jun 4, 2018 •
edited
Loading

Follow-up of ros2/rclcpp#481

  • Build Status

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jun 4, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 4, 2018
Merged
@mikaelarguedas mikaelarguedas self-assigned this Jun 4, 2018
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 4, 2018
@mikaelarguedas mikaelarguedas requested a review from sloretz June 4, 2018 07:43
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 4, 2018
Merged
@mikaelarguedas
Copy link
Member Author

Requested review from @dirk-thomas as build cop and from @sloretz as original committer

@mikaelarguedas mikaelarguedas merged commit e412a60 into ros2 Jun 4, 2018
@mikaelarguedas mikaelarguedas deleted the remove_parameter_variant branch June 4, 2018 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

@mikaelarguedas mikaelarguedas

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @dirk-thomas