-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to use upstream Python3 CMake Logic #6
Comments
Additional motivation ros2/rosidl_python#137 |
Assigned self since I have a little time to look at this. |
@cottsay I notice RHEL8 is using CMake 3.11.4. Is it ok to make packages in ROS Rolling require CMake 3.12? Will ROS Humble target a newer version of RHEL with a newer CMake version? |
It's actually 3.18: ros-infrastructure/rep#323 |
@sloretz Did all of the work here get done? Can we close this? |
Hey there, FYI, CMake 3.27 is about to be released, which removes these deprecated modules. On distros with rolling releases like MacOS, this could become a problem shortly. |
I just merged in #7 , which fixes this problem. So closing. |
This module uses PythonInterp and PythonLibs both were deprecated as of Cmake 3.12
The destination we should use is Python3
Alternatively the new upstream modules may have enough capabilities to not even need this module itself.
The text was updated successfully, but these errors were encountered: