Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use upstream Python3 CMake Logic #6

Closed
tfoote opened this issue Jul 24, 2021 · 8 comments
Closed

Upgrade to use upstream Python3 CMake Logic #6

tfoote opened this issue Jul 24, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tfoote
Copy link

tfoote commented Jul 24, 2021

This module uses PythonInterp and PythonLibs both were deprecated as of Cmake 3.12

The destination we should use is Python3

Alternatively the new upstream modules may have enough capabilities to not even need this module itself.

@tfoote tfoote added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2021
@sloretz
Copy link
Contributor

sloretz commented Jul 26, 2021

Additional motivation ros2/rosidl_python#137

@sloretz sloretz self-assigned this Jul 26, 2021
@sloretz
Copy link
Contributor

sloretz commented Jul 26, 2021

Assigned self since I have a little time to look at this.

@sloretz
Copy link
Contributor

sloretz commented Aug 3, 2021

@cottsay I notice RHEL8 is using CMake 3.11.4. Is it ok to make packages in ROS Rolling require CMake 3.12? Will ROS Humble target a newer version of RHEL with a newer CMake version?

@cottsay
Copy link
Member

cottsay commented Aug 3, 2021

It's actually 3.18: ros-infrastructure/rep#323

@clalancette
Copy link
Contributor

@sloretz Did all of the work here get done? Can we close this?

@sloretz
Copy link
Contributor

sloretz commented Mar 28, 2022

@sloretz Did all of the work here get done? Can we close this?

No. A lot of the work got done, but this critical piece did not: #7

It's been too long for me to remember what's blocking it.

@Ryanf55
Copy link

Ryanf55 commented Jul 12, 2023

Hey there, FYI, CMake 3.27 is about to be released, which removes these deprecated modules. On distros with rolling releases like MacOS, this could become a problem shortly.
https://cmake.org/cmake/help/latest/release/3.27.html#deprecated-and-removed-features

@clalancette
Copy link
Contributor

I just merged in #7 , which fixes this problem. So closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants