Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindPython3 explicitly instead of FindPythonInterp implicitly #254

Merged
merged 3 commits into from
Aug 9, 2021
Merged

FindPython3 explicitly instead of FindPythonInterp implicitly #254

merged 3 commits into from
Aug 9, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 5, 2021 •
edited
Loading

This makes qt_gui_cpp use FindPython3. Currently this code implicitly depends on ament_cmake_core finding FindPythonInterp for it.

@cottsay this PR needs a rolling specific branch such as master/main/rolling-devel. Personally I like main, any preferences yourself? edit: main branch created

Marking as draft because this PR needs changes in python_qt_binding to depend on FindPython3 edit: Those have been merged ros-visualization/python_qt_binding#107

Related to ros2/python_cmake_module#6
Blocks ament/ament_cmake#355

@sloretz
First pass using FindPython3
1519f2f 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz self-assigned this Aug 5, 2021
@cottsay
Copy link
Member

cottsay commented Aug 5, 2021

Personally I like main, any preferences yourself?

I think main is a good choice as well.

@sloretz sloretz changed the base branch from galactic-devel to main August 6, 2021 16:42
@sloretz
Target is Python3:: not Python::
49f5a9e 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz mentioned this pull request Aug 6, 2021
Merged
@sloretz sloretz changed the title First pass using FindPython3 FindPython3 explicitly instead of FindPythonInterp implicitly Aug 6, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Aug 6, 2021

CI (build: --packages-above-and-dependencies qt_gui_cpp test: --packages-above qt_gui_cpp)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Misc uses of FindPython3
5ee38af 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author

sloretz commented Aug 6, 2021 •
edited
Loading

Rerun of CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status - failed to delete workspace
    • rerun Build Status
  • Windows Build Status

@sloretz sloretz merged commit 26a9c4d into main Aug 9, 2021
@sloretz sloretz deleted the use_FindPython3_visualization branch August 9, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @cottsay @nuclearsandwich