Don't check history depth if RMW_QOS_POLICY_HISTORY_KEEP_ALL (#593)

Signed-off-by: Dan Rose <dan@digilabs.io> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
ros2 · Apr 9, 2020 · 048f02a · 048f02a
1 parent c2212d1
commit 048f02a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/rcl/test/rcl/test_get_actual_qos.cpp b/rcl/test/rcl/test_get_actual_qos.cpp
@@ -171,9 +171,9 @@ TEST_P_RMW(TestPublisherGetActualQoS, test_publisher_get_qos_settings)
   EXPECT_EQ(
     qos->history,
     parameters.qos_expected.history);
-  EXPECT_EQ(
-    qos->depth,
-    parameters.qos_expected.depth);
+  if (parameters.qos_expected.history == RMW_QOS_POLICY_HISTORY_KEEP_LAST) {
+    EXPECT_EQ(qos->depth, parameters.qos_expected.depth);
+  }
   EXPECT_EQ(
     qos->reliability,
     parameters.qos_expected.reliability);
@@ -226,9 +226,9 @@ TEST_P_RMW(TestSubscriptionGetActualQoS, test_subscription_get_qos_settings)
   EXPECT_EQ(
     qos->history,
     parameters.qos_expected.history);
-  EXPECT_EQ(
-    qos->depth,
-    parameters.qos_expected.depth);
+  if (parameters.qos_expected.history == RMW_QOS_POLICY_HISTORY_KEEP_LAST) {
+    EXPECT_EQ(qos->depth, parameters.qos_expected.depth);
+  }
   EXPECT_EQ(
     qos->reliability,
     parameters.qos_expected.reliability);