rcl_send_response returns RCL_RET_TIMEOUT. #1080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kghost
force-pushed
the
rolling
branch
3 times, most recently
from
0ab9550 to
ba9ceea
Compare
part of ros2/ros2#1253 We hit this problem where a broken client crashes the service executor. With this change we can fix it in rclcpp. Note: this is same as ros2#1048 which is not been taken attention for a while. Signed-off-by: Zang MingJie <zealot0630@gmail.com>
|
Closing as duplicate of #1048 - @fujitatomoya is there anything blocking us from moving forward on that one? |
|
@emersonknapp see ros2/rclcpp#2215 (comment), i do not figure out what/how we should do on client with this return code yet. that is the reason i was hesitating to merge #1048... any ideas? probably we want to keep the discussion on ros2/rclcpp#2215 to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ros2/ros2#1253
We hit this problem where a broken client crashes the service executor. With this change we can fix it in rclcpp.
Note: this is same as #1048 which is not taken attention for a while.