Properly initialize the char array used in type hash calculations. #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
|
Pulls: #1182
|
ahcorde
approved these changes
Sep 17, 2024
|
https://github.com/Mergifyio backport jazzy |
|
should we backport this to |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
…1182) Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit bfe00f7)
Iron, yes. This code didn't exist in humble, so not needed there. |
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
…1182) Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit bfe00f7)
clalancette
added a commit
that referenced
this pull request
Sep 17, 2024
…1182) (#1183) Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit bfe00f7) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Sep 17, 2024
…1182) (#1184) Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit bfe00f7) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were zero initializing it and only setting up one of its fields. But that doesn't totally properly initialize it; we really should call rcutils_char_array_init to make sure everything is initialized. Do that in the live source, as well as in the test for it.
This bug was exposed by ros2/rcutils#478 . @fujitatomoya @emersonknapp FYI