Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove todo that doesnt seem necessary anymore #161

Merged
merged 1 commit into from
Aug 30, 2017
Merged

remove todo that doesnt seem necessary anymore #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rcl/test/rcl/test_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ TEST_F(CLASSNAME(TestPublisherFixture, RMW_IMPLEMENTATION), test_publisher_nomin
std_msgs__msg__String__init(&msg);
ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, "testing"));
ret = rcl_publish(&publisher, &msg);
// TODO(wjwwood): re-enable this fini when ownership of the string is resolved.
// currently with Connext we will spuriously get a double free here.
// std_msgs__msg__String__fini(&msg);
std_msgs__msg__String__fini(&msg);
ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
}

Expand Down
4 changes: 1 addition & 3 deletions rcl/test/rcl/test_subscription.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,7 @@ TEST_F(CLASSNAME(TestSubscriptionFixture, RMW_IMPLEMENTATION), test_subscription
std_msgs__msg__String__init(&msg);
ASSERT_TRUE(rosidl_generator_c__String__assign(&msg.data, test_string));
ret = rcl_publish(&publisher, &msg);
// TODO(wjwwood): re-enable this fini when ownership of the string is resolved.
// currently with Connext we will spuriously get a double free here.
// std_msgs__msg__String__fini(&msg);
std_msgs__msg__String__fini(&msg);
ASSERT_EQ(RCL_RET_OK, ret) << rcl_get_error_string_safe();
}
bool success;
Expand Down