Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.6.0 #334

Closed
wants to merge 1 commit into from
Closed

Prepare 0.6.0 #334

wants to merge 1 commit into from

Conversation

nuclearsandwich
Copy link
Member

I generated and edited changelogs for this repository using my best judgement but I think it would be optimal of folks with more context also gave them a once-over.

I may release this as-is over the weekend to unblock further crystal releases but changelog modifications can come after-the-fact too.

@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Nov 17, 2018
@nuclearsandwich nuclearsandwich self-assigned this Nov 17, 2018
@jacobperron
Copy link
Member

The changelogs look okay to me. It looks like there were some API changes that are not backwards compatible (e.g. #285). Does this constitute a major version bump?

@dirk-thomas
Copy link
Member

dirk-thomas commented Nov 18, 2018

A minor version bump pre 1.0 is semantically a "major" bump allowing any kind of breakage.

@nuclearsandwich
Copy link
Member Author

There was a PR that went in after I'd set this up so I pulled in the latest master updated changelogs and released that instead of this as 0.6.0.

@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Nov 19, 2018
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactive, lgtm.

@wjwwood wjwwood deleted the prepare-0.6.0 branch November 19, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants