Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit dependency on rcl_logging_log4cxx #435

Merged
merged 1 commit into from
May 9, 2019
Merged

add explicit dependency on rcl_logging_log4cxx #435

merged 1 commit into from
May 9, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented May 9, 2019 •
edited
Loading

Makes it possible for the devel / PR jobs to pass, e.g. http://build.ros2.org/view/Ddev/job/Ddev__rcl__ubuntu_bionic_amd64/21/

@dirk-thomas
add explicit dependency on rcl_logging_log4cxx
3aab928 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels May 9, 2019
@dirk-thomas dirk-thomas self-assigned this May 9, 2019
wjwwood
wjwwood approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, equivalent to https://github.com/ros2/rmw_implementation/blob/master/rmw_implementation/package.xml#L14-L21

@dirk-thomas dirk-thomas merged commit 816ce67 into master May 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/explicit-logging-dep branch May 9, 2019 21:20
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label May 9, 2019
@dirk-thomas
Copy link
Member Author

Similar to https://github.com/ros2/rmw_implementation/blob/7e88ba2afd6b6b0066c4f7b5fd6ed4aaa9d92667/rmw_implementation/package.xml#L14-L21

@dirk-thomas dirk-thomas mentioned this pull request May 14, 2019
Merged
clalancette added a commit that referenced this pull request May 14, 2019
@clalancette
Revert "add explicit dependency on rcl_logging_log4cxx (#435)"
1e86e7f 
This reverts commit 816ce67.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas pushed a commit that referenced this pull request May 15, 2019
@clalancette @dirk-thomas
Revert "Changes the default 3rd party logger from rcl_logging_noop to… (
667443b 
#436)

* Revert "Changes the default 3rd party logger from rcl_logging_noop to rcl_logging_log4cxx (#425)"

This reverts commit ac8ee90.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Revert "add explicit dependency on rcl_logging_log4cxx (#435)"

This reverts commit 816ce67.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

* Add dependency on rcl_logging_noop.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @wjwwood