Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to '--ros-args ... [--]'-based ROS args extraction #477

Merged
merged 9 commits into from
Aug 7, 2019
Merged

Migrate to '--ros-args ... [--]'-based ROS args extraction #477

merged 9 commits into from
Aug 7, 2019

Commits on Jul 31, 2019

  1. Migrate to '--ros-args ... [--]'-based ROS args extraction 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d8e862f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Extend rcl arguments API to retrieve unparsed ROS args. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    ab0be89 View commit details
    Browse the repository at this point in the history

  2. Adapt rcl arguments tests. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    655dad4 View commit details
    Browse the repository at this point in the history

  3. Complete unparsed ROS args functionality. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    aa717ae View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    98d916f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Extend rcl arguments test coverage. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    8738f9b View commit details
    Browse the repository at this point in the history

  2. Adapt more rcl tests to use --ros-args. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    e2848fa View commit details
    Browse the repository at this point in the history

  3. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    a492d23 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Ignore duplicate --ros-args flags. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    9399614 View commit details
    Browse the repository at this point in the history