Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement functions to get publisher and subcription informations like QoS policies from topic name #511

Merged
merged 17 commits into from
Jan 14, 2020
Merged

Implement functions to get publisher and subcription informations like QoS policies from topic name #511

merged 17 commits into from
Jan 14, 2020

Commits on Dec 14, 2019

  1. Added functions to get qos policies 

    - rcl_get_qos_for_publishers to get the qos policies for all publishers
to a topic
- rcl_get_qos_for_subscribers to get the qos policies for all
subscribers to a topic

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    4110b12 View commit details
    Browse the repository at this point in the history

  2. - Implemented 

      - rcl_get_publishers_info_by_topic
  - rcl_get_subscriptions_info_by_topic
- Wrote tests for the same

Note: colcon build --packages-up-to rcl && colcon test --packages-select rcl && colcon test-result --verbose --test-result-base build/rcl
runs successfully without any errors or failures.

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    05ab30e View commit details
    Browse the repository at this point in the history

  3. Better error handling and avoiding error message replacement in 

    __rcl_get_info_by_topic

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    25e580b View commit details
    Browse the repository at this point in the history

  4. Fixed linter issues 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    56c7d8b View commit details
    Browse the repository at this point in the history

  5. - Removed tests for info_by_topic functions from test_graph to 

    test_info_by_topic to prevent timeouts on test_graph

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    f8a7b02 View commit details
    Browse the repository at this point in the history

  6. Removed unused headers from test_info_by_topic.cpp 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    86de8eb View commit details
    Browse the repository at this point in the history

  7. Increased TIMEOUT for test_info_by_topic 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    60ef38d View commit details
    Browse the repository at this point in the history

  8. - Better comments in the test 

    - Following naming convention for func typedefs

Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    94af172 View commit details
    Browse the repository at this point in the history

  9. Added tests to verify the output of rmw_get_info_by_topic functions 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    03cc14a View commit details
    Browse the repository at this point in the history

  10. Handles changes to the headers in rmw 

    Signed-off-by: Jaison Titus <jaisontj92@gmail.com>
    @jaisontj @mm318
    jaisontj authored and mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    dee951b View commit details
    Browse the repository at this point in the history

  11. address PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    3b6531e View commit details
    Browse the repository at this point in the history

  12. fix unit test failures 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    fcd26b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. address PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    713b1ec View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. address more PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    a90c33a View commit details
    Browse the repository at this point in the history

  2. rename *topic_info* to *topic_endpoint_info* 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    01ab304 View commit details
    Browse the repository at this point in the history

  3. fix formatting 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    200b78b View commit details
    Browse the repository at this point in the history

  4. update the docstring regarding no_mangle as suggested 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    dc73872 View commit details
    Browse the repository at this point in the history