Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle zero non-ROS specific args properly in rcl_remove_ros_arguments #518

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Handle zero non-ROS specific args properly in rcl_remove_ros_arguments #518

merged 3 commits into from
Oct 15, 2019

Commits on Oct 11, 2019

  1. Handle zero non-ROS specific args properly in rcl_remove_ros_arguments 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    f7da89e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Test rcl_remove_ros_args behavior with invalid input. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Oct 15, 2019
    2 Configuration menu
    Copy the full SHA
    002cd09 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    4e5ecfe View commit details
    Browse the repository at this point in the history