Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute topic name for rosout #549

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Use absolute topic name for rosout #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a764259
Use '/rosout' instead of 'rosout' as topic name
ivanpauno Dec 5, 2019
c68ed31
Correct test
ivanpauno Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rcl/src/rcl/logging_rosout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extern "C"
{
#endif

#define ROSOUT_TOPIC_NAME "rosout"
#define ROSOUT_TOPIC_NAME "/rosout"

/* Return RCL_RET_OK from this macro because we won't check throughout rcl if rosout is
* initialized or not and in the case it's not we want things to continue working.
Expand Down
2 changes: 1 addition & 1 deletion rcl/test/rcl/test_logging_rosout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class TEST_FIXTURE_P_RMW (TestLoggingRosoutFixture)
// create rosout subscription
const rosidl_message_type_support_t * ts =
ROSIDL_GET_MSG_TYPE_SUPPORT(rcl_interfaces, msg, Log);
const char * topic = "rosout";
const char * topic = "/rosout";
this->subscription_ptr = new rcl_subscription_t;
*this->subscription_ptr = rcl_get_zero_initialized_subscription();
rcl_subscription_options_t subscription_options = rcl_subscription_get_default_options();
Expand Down