Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TestInfoByTopicFixture unit tests for more rmw_implementations #583

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Enable TestInfoByTopicFixture unit tests for more rmw_implementations #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions rcl/test/rcl/test_info_by_topic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,9 @@ class CLASSNAME (TestInfoByTopicFixture, RMW_IMPLEMENTATION) : public ::testing:
const char * test_graph_node_name = "test_graph_node";
rmw_topic_endpoint_info_array_t topic_endpoint_info_array;
const char * const topic_name = "valid_topic_name";
bool is_fastrtps, is_cyclonedds;

void SetUp()
{
is_fastrtps = (std::string(rmw_get_implementation_identifier()).find("rmw_fastrtps") == 0);
is_cyclonedds = (std::string(rmw_get_implementation_identifier()).find("rmw_cyclonedds") == 0);
rcl_ret_t ret;
rcl_init_options_t init_options = rcl_get_zero_initialized_init_options();
ret = rcl_init_options_init(&init_options, rcl_get_default_allocator());
Expand Down Expand Up @@ -324,10 +321,6 @@ TEST_F(
CLASSNAME(TestInfoByTopicFixture, RMW_IMPLEMENTATION),
test_rcl_get_publishers_subscription_info_by_topic)
{
// This is implemented only in fastrtps and cyclone currently.
if (!is_fastrtps && !is_cyclonedds) {
GTEST_SKIP();
}
rmw_qos_profile_t default_qos_profile = rmw_qos_profile_system_default;
default_qos_profile.history = RMW_QOS_POLICY_HISTORY_KEEP_LAST;
default_qos_profile.depth = 0;
Expand Down