Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversions between rmw_localhost_only_t and bool #670

Merged
merged 7 commits into from
Jun 3, 2020
Merged

Fix conversions between rmw_localhost_only_t and bool #670

merged 7 commits into from
Jun 3, 2020

Commits on Jun 2, 2020

  1. Check for case RMW_LOCALHOST_ONLY_DISABLED in init_options 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    364b772 View commit details
    Browse the repository at this point in the history

  2. Take init value from node context 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3093642 View commit details
    Browse the repository at this point in the history

  3. Convert enum variable to boolean 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    442615d View commit details
    Browse the repository at this point in the history

  4. Remove extra check 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    ffae768 View commit details
    Browse the repository at this point in the history

  5. Remove not needed reference and dereference 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c992146 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Change rcl_get_localhost_only to match signature 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    d45ff22 View commit details
    Browse the repository at this point in the history

  2. Add parenthesis to make clearer precedence 

    Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545
    Blast545 committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    04dfa57 View commit details
    Browse the repository at this point in the history