Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport Foxy] Update QD #843

Merged
merged 8 commits into from
Nov 5, 2020
Merged

[Backport Foxy] Update QD #843

merged 8 commits into from
Nov 5, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 27, 2020

No description provided.

christophebedard and others added 4 commits October 27, 2020 15:19
@christophebedard @ahcorde
Update tracetools' QL to 2 in rcl's QD (#690)
f299c60 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@Blast545 @ahcorde
Fix link to latest API docs (#692)
fa4e9c6 
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@ahcorde
Update quality declaration and coverage (#674)
e5fbbb4 
* Update quality level and coverage

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed wording and links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated QD

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
udpate QD links to foxy
de0256a 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from brawner October 27, 2020 14:21
@ahcorde ahcorde self-assigned this Oct 27, 2020
christophebedard and others added 2 commits October 29, 2020 09:03
@christophebedard @ahcorde
Update tracetools QL and add to rcl_lifecycle's QD (#845)
2cb858c 
List tracetools in rcl_lifecycle's QD

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@ahcorde
update QL dependencies on rcl_yaml_param_parser
533d7bf 
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
chapulina suggested changes Oct 30, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several levels need fixing

rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_lifecycle/README.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl_yaml_param_parser/README.md Outdated Show resolved Hide resolved
@chapulina chapulina mentioned this pull request Oct 30, 2020
Merged
@ahcorde
Updated QD
ed05c9f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina November 3, 2020 08:02
chapulina
chapulina reviewed Nov 3, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more links

rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rcl/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
@ahcorde
Updated QD
4062119 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina November 4, 2020 07:11
chapulina
chapulina approved these changes Nov 4, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahcorde ahcorde merged commit 4376552 into foxy Nov 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/foxy/qd branch November 5, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard left review comments

@chapulina chapulina chapulina approved these changes

@brawner brawner Awaiting requested review from brawner

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @christophebedard @chapulina @Blast545