Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up documentation build for rcl_lifecycle when using rosdoc2 #938

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix up documentation build for rcl_lifecycle when using rosdoc2 #938

merged 1 commit into from
Sep 28, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 21, 2021

Similar to #932.

@hidmic
Fix up documentation build for rcl_lifecycle when using rosdoc2
c8cf787 
* Handle RCL_WARN_UNUSED
* Avoid duplicate type names

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from clalancette September 21, 2021 19:20
clalancette
clalancette approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@hidmic
Copy link
Contributor Author

hidmic commented Sep 27, 2021 •
edited
Loading

CI above rcl_lifecycle (plus dependencies):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status (unrelated test failures)
  • Windows Build Status

@hidmic hidmic mentioned this pull request Sep 28, 2021
Merged
@hidmic
Copy link
Contributor Author

hidmic commented Sep 28, 2021

I'll move forward with this one and release so we can get ros2/rclcpp#1788 to pass its Rpr job.

@hidmic hidmic merged commit 991240d into master Sep 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-rcl_lifecycle-docs branch September 28, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @clalancette