-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added include dir to installation of rcl_logging_log4cxx. #7
Conversation
@thomas-moulard - please run the following CI job:
|
This looks like an unrelated flake8 regressions in the idl generator on all platforms.
Possibly related to ros2/rosidl#371 @jacobperron |
Looks like the regression may have been fixed here too: ros2/rosidl#373 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me with green CI.
The CI failed some tests. This is now hitting a
There's a recent change related here: ros2/rcl#405 |
Oh, I see what happened. We merged ros2/rcl#405, which means that ros2/rcl#425 needs a rebase now. As @dirk-thomas suggested, this is only installing stuff that wasn't there before, so I'm going to merge this anyway. |
Fixes issue #5. This enables compiling ROS2 with log4cxx (by setting RCL_LOGGING_IMPLEMENTATION to rcl_logging_log4cxx).