Deprecate publish call taking a raw ptr. Stop deprecating publish met…

…hods in LifecyclePublisher. Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
ros2 · May 2, 2019 · 892e1f1 · 892e1f1
1 parent 62058d6
commit 892e1f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/rclcpp/include/rclcpp/publisher.hpp b/rclcpp/include/rclcpp/publisher.hpp
@@ -144,6 +144,8 @@ class Publisher : public PublisherBase
     this->publish(std::move(unique_msg));
   }
 
+  [[deprecated(
+    "Use publish(*msg). Check against nullptr before calling if necessary.".)]]
   virtual void
   publish(const MessageT * msg)
   {

diff --git a/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp b/rclcpp_lifecycle/include/rclcpp_lifecycle/lifecycle_publisher.hpp
@@ -96,9 +96,6 @@ class LifecyclePublisher : public LifecyclePublisherInterface,
    * was enabled or disabled and forwards the message
    * to the actual rclcpp Publisher base class
    */
-  [[deprecated(
-    "publishing an unique_ptr is prefered when using intra process communication."
-    " If using a shared_ptr, use publish(*msg).")]]
   virtual void
   publish(std::shared_ptr<const MessageT> msg)
   {