Skip to content

Commit

Permalink
Make sure the Waitable class has a virtual destructor.
Browse files Browse the repository at this point in the history
Noticed while reviewing this issue.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
  • Loading branch information
clalancette committed May 28, 2020
1 parent 5632fa0 commit c9c4253
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions rclcpp/include/rclcpp/waitable.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ class Waitable
public:
RCLCPP_SMART_PTR_DEFINITIONS_NOT_COPYABLE(Waitable)

RCLCPP_PUBLIC
virtual ~Waitable() = default;

/// Get the number of ready subscriptions
/**
* Returns a value of 0 by default.
Expand Down

0 comments on commit c9c4253

Please sign in to comment.