Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍🌾 Flaky TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers failing in Windows #2436

Closed
Crola1702 opened this issue Feb 23, 2024 · 1 comment

Comments

@Crola1702
Copy link
Contributor

Bug report

Required Info:

  • Operating System:
    • Windows
  • Installation type:
    • Source
  • Version or commit hash:
    • Rolling
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

  1. Run a build in nightly_win_rep
  2. See TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers test failure

Expected behavior

Test should pass

Actual behavior

Test is failing

Additional information

Reference build: https://ci.ros2.org/view/nightly/job/nightly_win_rep/3273/#showFailuresLink

Test regressions:

Log output:

[ RUN      ] TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers
C:\ci\ws\src\ros2\rclcpp\rclcpp\test\rclcpp\test_timers_manager.cpp(405): error: Expected: (t1_runs + 5) < (t2_runs), actual: 10 vs 11

[  FAILED  ] TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers (16 ms)

Test was added 3 weeks ago, and it's failing flaky since then (#2375)

Crola1702 added a commit to osrf/buildfarm-tools that referenced this issue Feb 23, 2024
New issues:
* ros2/rclcpp#2435
* ros2/rclcpp#2436

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 changed the title 🧑‍🌾 TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers failing in Windows 🧑‍🌾 Flaky TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers failing in Windows Feb 27, 2024
@Crola1702
Copy link
Contributor Author

This was fixed in: #2468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant