Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More and safer node interfaces' getters #1035

Closed
wants to merge 4 commits into from
Closed

More and safer node interfaces' getters #1035

wants to merge 4 commits into from

Commits on Mar 30, 2020

  1. Add nullptr checks to node interfaces' getters. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d0d39ea View commit details
    Browse the repository at this point in the history

  2. Introduce node interfaces' getters that yield shared ownership. 

    Changes apply to NodeBaseInterface, NodeTimersInterface and NodeTopicsInterface getters.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    a4e7681 View commit details
    Browse the repository at this point in the history

  3. Add all missing node interfaces' getters. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    70d7fa1 View commit details
    Browse the repository at this point in the history

  4. Make rclcpp_action::create_*() functions use node interfaces' getters. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    4319834 View commit details
    Browse the repository at this point in the history