Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid callback_group deprecation #1108

Merged
merged 1 commit into from
May 8, 2020
Merged

avoid callback_group deprecation #1108

merged 1 commit into from
May 8, 2020

Conversation

Karsten1987
Copy link
Contributor

I got a deprecation warning when building on OSX.

@Karsten1987
avoid callback_group deprecation
f2583b3 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
clalancette
clalancette approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the same thing yesterday, I just didn't get a chance to open a PR. Looks good to me with green(ish) CI.

@Karsten1987
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Karsten1987
Copy link
Contributor Author

That test failure on OSX is unrelated and happens on the nightlies as well.

@Karsten1987 Karsten1987 merged commit e24f402 into master May 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the avoid_deprecation branch May 8, 2020 16:04
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
@Karsten1987
avoid callback_group deprecation (ros2#1108)
1404c23 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karsten1987 @clalancette