add rcl_action_client_options when creating action client.

[fujitatomoya]

fix #1118.

[fujitatomoya]

I guess that it needs to be rebased.

[fujitatomoya]

@ros-pull-request-builder retest this please

[fujitatomoya]

source build with ros2/ros2@4eece71,

i do not see the following build error reported by CI,
http://build.ros2.org/job/Fpr__rclcpp__ubuntu_focal_amd64/80/console#console-section-15

08:03:23 /tmp/ws/src/rclcpp/rclcpp/src/rclcpp/context.cpp: In function ‘void rclcpp_logging_output_handler(const rcutils_log_location_t*, int, const char*, rcutils_time_point_value_t, const char*, __va_list_tag (*)[1])’:
08:03:23 /tmp/ws/src/rclcpp/rclcpp/src/rclcpp/context.cpp:66:12: error: ‘rcl_logging_multiple_output_handler’ was not declared in this scope; did you mean ‘rcutils_logging_console_output_handler’?
08:03:23    66 |     return rcl_logging_multiple_output_handler(
08:03:23       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
08:03:23       |            rcutils_logging_console_output_handler
08:03:23 /tmp/ws/src/rclcpp/rclcpp/src/rclcpp/context.cpp:67:56: error: return-statement with a value, in function returning ‘void’ [-fpermissive]
08:03:23    67 |       location, severity, name, timestamp, format, args);
08:03:23       |                                                        ^
08:03:23 /tmp/ws/src/rclcpp/rclcpp/src/rclcpp/context.cpp: In member function ‘virtual void rclcpp::Context::init(int, const char* const*, const rclcpp::InitOptions&)’:
08:03:23 /tmp/ws/src/rclcpp/rclcpp/src/rclcpp/context.cpp:146:13: error: ‘rcl_logging_configure_with_output_handler’ was not declared in this scope; did you mean ‘rcutils_logging_console_output_handler’?
08:03:23   146 |       ret = rcl_logging_configure_with_output_handler(
08:03:23       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
08:03:23       |             rcutils_logging_console_output_handler
08:03:23 make[2]: *** [CMakeFiles/rclcpp.dir/build.make:220: CMakeFiles/rclcpp.dir/src/rclcpp/context.cpp.o] Error 1
08:03:23 make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/rclcpp.dir/all] Error 2
08:03:23 make: *** [Makefile:141: all] Error 2
08:03:23 ---

i do not think this is related to my fix.

[fujitatomoya]

@hidmic

friendly ping.

[wjwwood]

Seems reasonable to me, but it would be better to have a C++ based option structure.

[jacobperron]

LGTM

We should hold for after the release of Foxy.

[jacobperron]

it would be better to have a C++ based option structure.

+1
If we do this we should also add a C++ structure for the server options. This sounds like a good follow-up PR.

[fujitatomoya]

@jacobperron @hidmic @wjwwood

merge conflicts are resolved, could we have a go for merge?

[jacobperron]

CI for packages above rclcpp_action:

• Linux
• Linux-aarch64
• macOS
• Windows

Edit: The large number of linter failures are unrelated, I'll re-trigger once the issue has been resolved elsewhere.

Edit: I've triggered a new build.

[jacobperron]

@fujitatomoya Thanks for the patch!