Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allow spin_until_future_complete to accept std::future (#1113)" #1159

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Revert "Allow spin_until_future_complete to accept std::future (#1113)" #1159

merged 1 commit into from
Jun 9, 2020

Conversation

dirk-thomas
Copy link
Member

This reverts commit 898a30e since it fails to build: Build Status

@dirk-thomas dirk-thomas self-assigned this Jun 9, 2020
@dirk-thomas dirk-thomas mentioned this pull request Jun 9, 2020
Merged
@dirk-thomas dirk-thomas merged commit bba9dce into master Jun 9, 2020
@dirk-thomas dirk-thomas deleted the revert-1113-feature/spin-until-future-complete branch June 9, 2020 04:39
@dirk-thomas
Copy link
Member Author

CI post-revert: Build Status

ivanpauno added a commit that referenced this pull request Jun 9, 2020
@ivanpauno
Revert "Revert "Allow spin_until_future_complete to accept std::future (
ab20581 
#1113)" (#1159)"

This reverts commit bba9dce.
@ivanpauno ivanpauno mentioned this pull request Jun 9, 2020
Merged
ivanpauno added a commit that referenced this pull request Jun 9, 2020
@ivanpauno
Revert "Revert "Allow spin_until_future_complete to accept std::future (
32704a9 
#1113)" (#1159)"

This reverts commit bba9dce.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit that referenced this pull request Jun 10, 2020
@ivanpauno
Revert "Revert "Allow spin_until_future_complete to accept std::future (
0fa68d5 
#1113)" (#1159)" (#1160)

This reverts commit bba9dce.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
@dirk-thomas
Revert "Allow spin_until_future_complete to accept std::future (ros2#…
037659c 
…1113)" (ros2#1159)

This reverts commit 898a30e.
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
@ivanpauno
Revert "Revert "Allow spin_until_future_complete to accept std::future (
7ef258f 
ros2#1113)" (ros2#1159)" (ros2#1160)

This reverts commit bba9dce.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dirk-thomas