Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests type_support module #1308
Add tests type_support module #1308
Changes from 4 commits
bba1121
b027cca
bdd02e7
4bb4fe6
0ba1439
624d35c
05d3db0
040abc4
f9df887
35f474d
811ad25
5b0137c
2c9b77e
82d7ae7
e8af00e
7add35f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be part of the TestTypeSupport fixture? If you chopped up each check in
test_service_getters
into their own tests, you wouldn't need to create a second node here.Also, I think this function should return an
::testing::AssertionResult
, then you can wrap each call totest_type_support_init_fini
in anEXPECT_TRUE
. If there is a failure in this function, it will not only print out your custom failure message, but also the line intest_service_getters
where theEXPECT_TRUE
failed. Otherwise, if line 150 failed, you currently get no more helpful feedback than that there was a failure at line 150.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look to the complete I made based in your comments, let me know if you think this is ok