Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy] Fix implementation of NodeOptions::use_global_arguments() (#1176) #1372

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[foxy] Fix implementation of NodeOptions::use_global_arguments() (#1176) #1372

merged 1 commit into from
Oct 6, 2020

Commits on Oct 2, 2020

  1. Fix implementation of NodeOptions::use_global_arguments() (#1176) 

    `this->node_options_` might still be `nullptr` for a default initialized NodeOptions instance.
`use_global_arguments()` must return `this->use_global_arguments_`, in analogy to `NodeOptions::enable_rosout()`.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
    @meyerj @jacobperron
    meyerj authored and jacobperron committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    0a4847a View commit details
    Browse the repository at this point in the history